From: Jasper St. Pierre <jstpierre@mecheye.net>
Date: Wed, 2 Oct 2013 02:54:16 +0000 (-0400)
Subject: app: Use g_variant_lookup instead of dict iteration
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~3295
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=0256a6d47b9390ca46d30f4d1fd4f73495171947;p=gnome-shell.git

app: Use g_variant_lookup instead of dict iteration
---

diff --git a/src/shell-app.c b/src/shell-app.c
index 1f5017d26..9e16f807e 100644
--- a/src/shell-app.c
+++ b/src/shell-app.c
@@ -960,10 +960,8 @@ application_properties_changed (GDBusConnection *connection,
 {
   ShellApp *app = user_data;
   GVariant *changed_properties;
-  GVariantIter iter;
   gboolean busy = FALSE;
-  const gchar *key, *interface_name_for_signal;
-  GVariant *value;
+  const gchar *interface_name_for_signal;
 
   g_variant_get (parameters,
                  "(&s@a{sv}as)",
@@ -974,19 +972,7 @@ application_properties_changed (GDBusConnection *connection,
   if (g_strcmp0 (interface_name_for_signal, "org.gtk.Application") != 0)
     return;
 
-  g_variant_iter_init (&iter, changed_properties);
-  while (g_variant_iter_next (&iter, "{&sv}", &key, &value))
-    {
-      if (g_strcmp0 (key, "Busy") != 0)
-        {
-          g_variant_unref (value);
-          continue;
-        }
-
-      busy = g_variant_get_boolean (value);
-      g_variant_unref (value);
-      break;
-    }
+  g_variant_lookup (changed_properties, "Busy", "b", &busy);
 
   if (busy)
     shell_app_state_transition (app, SHELL_APP_STATE_BUSY);